[editorial][CI] Ensure markdownlint has proper exit status #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chalin
commented
Jul 25, 2023
chalin
commented
- Followup to [editorial] markdownlint in less then 1.5 sec #193
- Ensures that all files are checked by markdownlint, and that if issues are detected, then the overall task fails at the end
|
I'll seed an error, just for the purpose of testing the GH action failure. |
|
The GH action is now appropriately failing when there are md lint issues, e.g.: https://github.com/open-telemetry/semantic-conventions/actions/runs/5658821490/job/15330972724?pr=210. Removing the seeded error now. |
chalin
force-pushed
the
chalin-im-lint-exit-status-2023-07-25
branch
from
3b03a07
to
d526124
Compare
reyang
approved these changes
Jul 25, 2023
jsuereth
approved these changes
Jul 27, 2023
bryce-b
pushed a commit
to bryce-b/semantic-conventions
that referenced
this pull request
Aug 8, 2023
…metry#210) Co-authored-by: Josh Suereth <joshuasuereth@google.com>
rapphil
pushed a commit
to rapphil/semantic-conventions
that referenced
this pull request
Aug 14, 2023
…metry#210) Co-authored-by: Josh Suereth <joshuasuereth@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.